Skip to content

Conversation

dledda-r7
Copy link
Contributor

No description provided.

@smcintyre-r7
Copy link
Contributor

Do you have any background that you can provide on these changes? I see the cmd code was switched to powershell and that vs_installer.exe is now run. Is this required to unblock some other PR or remove something that was deprecated or broken? Lastly do you have any suggestions for testing it to make sure it's working correctly?

@smcintyre-r7 smcintyre-r7 self-assigned this Aug 25, 2025
@smcintyre-r7 smcintyre-r7 moved this from Todo to In Progress in Metasploit Kanban Aug 25, 2025
@dledda-r7
Copy link
Contributor Author

@zeroSteiner, this change was requested by @AlanFoster, i think (Alan correct me if I am wrong) this is used when we want to test something on metasploit-payloads repo with a metasploit-framework branch that is not rapid7/master.
The usage of powershell is required, so i switched everything to powershell. What we are doing here is updating the VS2022 installation to support XP and other stuff we need.

@adfoster-r7
Copy link
Contributor

adfoster-r7 commented Sep 1, 2025

Tested here: rapid7/metasploit-payloads#766

VS2022 build output:

https://github.com/rapid7/metasploit-payloads/actions/runs/17374128806/job/49316653585?pr=766

The logs show that the vs components install successfully:

Mon, 01 Sep 2025 10:09:25 GMT components have been successfully added

But, it looks like the build logs are missing - which would be useful for debugging build failures

Mon, 01 Sep 2025 10:09:29 GMT Id      : 5780
Mon, 01 Sep 2025 10:09:29 GMT Handles : 20
Mon, 01 Sep 2025 10:09:29 GMT CPU     : 0
Mon, 01 Sep 2025 10:09:29 GMT SI      : 2
Mon, 01 Sep 2025 10:09:29 GMT Name    : cmd
Mon, 01 Sep 2025 10:09:29 GMT
Mon, 01 Sep 2025 10:23:20 GMT

Based on the last two timestamps it looks like the build took around the time we'd expect it to take, but there's no logs present - it'd be great to fix that 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants