Skip to content

fix: remove _JAVA_OPTIONS parameter & environment #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: remove _JAVA_OPTIONS parameter & environment #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/executors/linux_android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
parameters:
java_options:
description: Java command options. Note that setting this will override the default options so you might need to supply those as well.
type: string
default: '-Xmx1024m -XX:+UnlockExperimentalVMOptions -XX:+UseContainerSupport'
gradle_options:
description: Gradle command options. Note that setting this will override the default options so you might need to supply those as well.
type: string
Expand All @@ -19,5 +15,4 @@ docker:
- image: reactnativecommunity/react-native-android:<<parameters.build_image_version>>
resource_class: <<parameters.resource_class>>
environment:
- _JAVA_OPTIONS: <<parameters.java_options>>
- GRADLE_OPTS: <<parameters.gradle_options>>
5 changes: 0 additions & 5 deletions src/jobs/android_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@ parameters:
description: Configure the android tests to run. Defaults to assembleAndroidTest
type: string
default: assembleAndroidTest
java_options:
description: Java command options. Note that setting this will override the default options so you might need to supply those as well.
type: string
default: '-Xmx1024m -XX:+UnlockExperimentalVMOptions -XX:+UseContainerSupport'
gradle_options:
description: Gradle command options. Note that setting this will override the default options so you might need to supply those as well.
type: string
Expand All @@ -66,7 +62,6 @@ parameters:

executor:
name: linux_android
java_options: <<parameters.java_options>>
gradle_options: <<parameters.gradle_options>>
build_image_version: <<parameters.build_image_version>>
resource_class: <<parameters.resource_class>>
Expand Down