Skip to content

Conversation

arekmaz
Copy link
Contributor

@arekmaz arekmaz commented Mar 5, 2019

Translations for Rendering Elements page

@netlify
Copy link

netlify bot commented Mar 5, 2019

Deploy preview for pl-reactjs ready!

Built with commit 1ed6105

https://deploy-preview-42--pl-reactjs.netlify.com

@jakubdrozdek jakubdrozdek added needs review A pull request ready to be reviewed needs +1 Needs another approval before merging labels Mar 5, 2019
Copy link
Member

@jakubdrozdek jakubdrozdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dodałem trochę poprawek, ale ogólnie wyszło dobrze :) Gratuluję pierwszego udanego tłumaczenia.

@jakubdrozdek jakubdrozdek added the needs author response Changes requested needing author's input label Mar 5, 2019
@arekmaz
Copy link
Contributor Author

arekmaz commented Mar 6, 2019

Dzięki, mógłbyś dopisać mnie koło tego tematu w progresie?

@jakubdrozdek jakubdrozdek removed the needs author response Changes requested needing author's input label Mar 6, 2019
@jakubdrozdek jakubdrozdek added this to the Core Pages milestone Mar 6, 2019
Copy link
Contributor

@g12i g12i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kilka luźnych sugestii


`embed:rendering-elements/update-rendered-element.js`

[](codepen://rendering-elements/update-rendered-element)

It calls `ReactDOM.render()` every second from a [`setInterval()`](https://developer.mozilla.org/en-US/docs/Web/API/WindowTimers/setInterval) callback.
Wywołuje on `ReactDOM.render()` z funkcji zwrotnej [`setInterval()`](https://developer.mozilla.org/pl/docs/Web/API/Window/setInterval) co sekundę.
Copy link
Contributor

@g12i g12i Mar 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nie pasuje mi to

z funkcji zwrotnej

Albo z wewnątrz funkcji zwrotnej ,albo we funkcji zwrotnej

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arekmaz
Copy link
Contributor Author

arekmaz commented Mar 6, 2019

Ok, poprawiłem.

@jakubdrozdek
Copy link
Member

Jak dla mnie jest wszystko ok.

Copy link
Contributor

@g12i g12i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@jakubdrozdek jakubdrozdek merged commit 19e89b0 into reactjs:master Mar 7, 2019
@jakubdrozdek jakubdrozdek added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging needs review A pull request ready to be reviewed labels Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants