Skip to content

fix(traverse): only visit paths, not nodes #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2020
Merged

fix(traverse): only visit paths, not nodes #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/resolveToValue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ function findScopePath(paths: Array<NodePath>, path: NodePath): ?NodePath {
function findLastAssignedValue(scope, name) {
const results = [];

traverseShallow(scope.path.node, {
traverseShallow(scope.path, {
visitAssignmentExpression: function(path) {
const node = path.node;
// Skip anything that is not an assignment to a variable with the
Expand Down
4 changes: 2 additions & 2 deletions src/utils/traverse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ type Visitor = (path: NodePath) => any;
* default.
*/
export function traverseShallow(
ast: ASTNode,
path: NodePath,
visitors: { [key: string]: Visitor },
): void {
visit(ast, { ...defaultVisitors, ...visitors });
visit(path, { ...defaultVisitors, ...visitors });
}

const ignore = () => false;
Expand Down