chore: declare return type of pipe()
methods by @template
#183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow IDEs and PHPStan to more correctly detect the type of objects returned from the
React\Stream\Util::pipe()
andReact\Stream\ReadableStreamInterface::pipe()
methods.After applying these changes, calling chains from
pipe()
methods will no longer result in PHPStan errors for the following code:Also, the IDE (using PhpStorm as an example) will be able to correctly understand the object type returned from the
pipe()
method. The following warning will no longer appear: