fix: handle missing blob attribute in shallow checkpoint savers (#80) #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrookins
approved these changes
Aug 11, 2025
Add defensive checks in AsyncShallowRedisSaver and ShallowRedisSaver to filter out documents with None or missing blob attributes when loading pending sends. This prevents AttributeError when querying checkpoint writes from the TASKS channel. Added comprehensive test for empty blob (b'') handling as suggested in PR review: - Test empty byte string in pending sends - Test various empty values (empty string, dict, list) - Verify proper handling in TASKS channel writes Fixes #80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add defensive checks in AsyncShallowRedisSaver and ShallowRedisSaver to filter out documents with None or missing blob attributes when loading pending sends. This prevents AttributeError when querying checkpoint writes from the TASKS channel.
Fixes #80