Skip to content

Conversation

AlBlanc
Copy link

@AlBlanc AlBlanc commented Aug 22, 2025

No description provided.

@PavelPashov
Copy link
Contributor

Hey @AlBlanc, thank you for the contribution! Could you confirm if the changes in docs folder are necessary? Additionally, please open a PR in the commands repo, similar to this one.

@AlBlanc
Copy link
Author

AlBlanc commented Aug 26, 2025

Hello @PavelPashov :)

About the change in docs... I just rebuilt the doc with the new command, I guess it is necessary, let me know your thoughts.

Yes, I forgot to make a PR to the commands repo. But I guess you wanted to mention this one ? The one you linked just have an empty commit.

@AlBlanc
Copy link
Author

AlBlanc commented Aug 26, 2025

Here is the PR

@PavelPashov
Copy link
Contributor

Hello @PavelPashov :)

About the change in docs... I just rebuilt the doc with the new command, I guess it is necessary, let me know your thoughts.

Yes, I forgot to make a PR to the commands repo. But I guess you wanted to mention this one ? The one you linked just have an empty commit.

Yes, thank you!

Copy link
Contributor

@PavelPashov PavelPashov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes related to the docs directory, as the documentation is automatically generated as part of the release workflow.

In addition, it would be great to include functional tests for the command, similar to the ones provided here.

@PavelPashov
Copy link
Contributor

Hey, @AlBlanc, we're planning a minor release soon, can you check my comments and let me know if we should try to include this

Co-authored-by: DEFLANDRE ALBAN <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants