Skip to content

Conversation

LadyTsukiko
Copy link
Contributor

Added support and tests for optional static segments in matchPath. According to the docs they should be supported but were not.

Before the fix the pattern "/user/admin?" would match "/user/admi" and "/user/admin" but not "/user".

Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: e6ea20f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 17, 2024

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@LadyTsukiko LadyTsukiko marked this pull request as draft July 17, 2024 08:46
@LadyTsukiko LadyTsukiko marked this pull request as ready for review July 17, 2024 08:59
@brophdawg11 brophdawg11 self-assigned this Jul 3, 2025
Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brophdawg11 brophdawg11 merged commit bb4a55e into remix-run:dev Aug 6, 2025
5 checks passed
Copy link
Contributor

github-actions bot commented Aug 7, 2025

🤖 Hello there,

We just published version 7.8.0-pre.3 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@brophdawg11
Copy link
Contributor

🤖 bad bot - this is not in 7.8.0 and will be in the next release

Copy link
Contributor

🤖 Hello there,

We just published version 7.8.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.8.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants