-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Fix support for optional static segments #11813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e6ea20f The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🤖 Hello there, We just published version Thanks! |
🤖 bad bot - this is not in 7.8.0 and will be in the next release |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Added support and tests for optional static segments in matchPath. According to the docs they should be supported but were not.
Before the fix the pattern "/user/admin?" would match "/user/admi" and "/user/admin" but not "/user".