Skip to content

Change RestClientOptions to MaxTimeout which is what it really is #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Change RestClientOptions to MaxTimeout which is what it really is #1804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/RestSharp/RestClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ public RestClient(HttpClient httpClient, RestClientOptions options, bool dispose
public RestClient(HttpMessageHandler handler, bool disposeHandler = true) : this(new HttpClient(handler, disposeHandler), true) { }

void ConfigureHttpClient(HttpClient httpClient) {
if (Options.Timeout > 0) httpClient.Timeout = TimeSpan.FromMilliseconds(Options.Timeout);
if (Options.MaxTimeout > 0) httpClient.Timeout = TimeSpan.FromMilliseconds(Options.MaxTimeout);
httpClient.DefaultRequestHeaders.UserAgent.ParseAdd(Options.UserAgent);
}

Expand Down
2 changes: 1 addition & 1 deletion src/RestSharp/RestClientOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public RestClientOptions(string baseUrl) : this(new Uri(Ensure.NotEmptyString(ba
public bool FollowRedirects { get; set; } = true;
public CookieContainer? CookieContainer { get; set; }
public string UserAgent { get; set; } = DefaultUserAgent;
public int Timeout { get; set; }
public int MaxTimeout { get; set; }
public Encoding Encoding { get; set; } = Encoding.UTF8;

/// <summary>
Expand Down