Skip to content

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Sep 8, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

PgSslMode::prefer means establishing an encrypted connection if the server supports it, and fall back to an unencrypted connection if an encrypted connection cannot be established, and it is also a recommended practice.
I think it is safe to set it to prefer at least for user-defined disable and prefer.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Sep 8, 2025
@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Sep 8, 2025

I think in lakekeeper services, should also set to prefer. WDYT @chenzl25

@chenzl25
Copy link
Contributor

chenzl25 commented Sep 9, 2025

I think in lakekeeper services, should also set to prefer. WDYT @chenzl25

Sure. I think you can change it in this PR directly.

@wcy-fdu wcy-fdu changed the title fix(cdc): change default ssl mode to prefer fix(cdc): fix some ssl mode issue Sep 9, 2025
@wcy-fdu wcy-fdu requested a review from hzxa21 September 9, 2025 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Type: Bug fix. Only for pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants