Skip to content

Conversation

mon3stera
Copy link
Contributor

Yesterday's update to moka changed the signature of invalidate, breaking the libfuse compilation.

@mon3stera mon3stera marked this pull request as ready for review September 24, 2025 14:50
@genedna genedna requested a review from Copilot September 25, 2025 01:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a compilation error in the PassthroughFS implementation caused by a breaking change in the moka crate's invalidate method signature.

  • Updates the invalidate method call to match the new moka API signature
  • Changes from passing a reference to the key to calling as_ref() on the key

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: mon3stera <[email protected]>

fix: update Cargo.toml

Signed-off-by: mon3stera <[email protected]>
Copy link
Collaborator

@Ivanbeethoven Ivanbeethoven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ivanbeethoven Ivanbeethoven added this pull request to the merge queue Sep 25, 2025
Merged via the queue into rk8s-dev:main with commit 9fe5d0a Sep 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants