Handle unbound encoding/decoding queues in aiortc track #1537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… inference consuming and filling strategies to handle the load
grzegorz-roboflow
requested review from
PawelPeczek-Roboflow,
yeldarby,
probicheaux and
hansent
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We observe RAM build-up on cloud instances when consuming webrtc streams with aiortc. Upon closer look it seems aiortc maintains unbound queues for storing frames before decoding, if decoding takes long time this queue grows in size resulting in high RAM utilization as well as extremely long latencies.
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Any specific deployment considerations
N/A
Docs
N/A