Skip to content

ASan: Run with verify_asan_link_order=0. #3491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ASan: Run with verify_asan_link_order=0. #3491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/RecordSession.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2223,6 +2223,8 @@ static ExeInfo read_exe_info(const string& exe_file) {
ElfFileReader reader(fd);
ret.arch = reader.arch();

// Don't try to modifiy LD_PRELOAD when rr itself is built with ASan
#ifndef __SANITIZE_ADDRESS__
DynamicSection dynamic = reader.read_dynamic();
for (auto& entry : dynamic.entries) {
if (entry.tag == DT_NEEDED && entry.val < dynamic.strtab.size()) {
Expand All @@ -2236,6 +2238,7 @@ static ExeInfo read_exe_info(const string& exe_file) {
}
}
}
#endif

auto syms = reader.read_symbols(".dynsym", ".dynstr");
for (size_t i = 0; i < syms.size(); ++i) {
Expand Down
4 changes: 4 additions & 0 deletions src/util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2461,6 +2461,10 @@ int __lsan_is_turned_off(void)
{
return rr_lsan_is_turned_off;
}
#include <sanitizer/asan_interface.h>
const char *__asan_default_options() {
return "verify_asan_link_order=0";
}
#endif

bool coredumping_signal_takes_down_entire_vm() {
Expand Down