-
Notifications
You must be signed in to change notification settings - Fork 31
Suggested edits to the interrupts chapter #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should explain further about proc macros here; it's a complicated concept in its own right. Maybe link to the Book of Macros?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, I think maybe link to the Macros section in the Rust Book (which then itself links to the Book of Macros)?
From skimming these just now, while the Book of Macros mentions ways to expand macros (like the Playground option), they don't mention the rust-analyzer command.
I think maybe it is worth mentioning briefly how to expand macros, so that someone reading this can get a quick understanding of roughly what the interrupts macro does without having to learn Macro syntax.
Thanks much for all your suggestions! We'll improve things as a result. |
I think this chapter is really good! It explains stuff very clearly.
I did find some typos and some things I think should be added.