Skip to content

Conversation

Tomer-Eliahu
Copy link
Contributor

I think this chapter is really good! It explains stuff very clearly.

I did find some typos and some things I think should be added.

@Tomer-Eliahu Tomer-Eliahu requested a review from a team as a code owner August 28, 2025 18:39
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should explain further about proc macros here; it's a complicated concept in its own right. Maybe link to the Book of Macros?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, I think maybe link to the Macros section in the Rust Book (which then itself links to the Book of Macros)?

From skimming these just now, while the Book of Macros mentions ways to expand macros (like the Playground option), they don't mention the rust-analyzer command.

I think maybe it is worth mentioning briefly how to expand macros, so that someone reading this can get a quick understanding of roughly what the interrupts macro does without having to learn Macro syntax.

@BartMassey
Copy link
Member

Thanks much for all your suggestions! We'll improve things as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants