Always maintain the invariant for TransactionSignature #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomarQ
reviewed
Jul 1, 2025
| odd_y_parity: false, | ||
| r: hex!("36b241b061a36a32ab7fe86c7aa9eb592dd59018cd0443adc0903590c16b02b0").into(), | ||
| s: hex!("5edcc541b4741c5cc6dd347c5ed9577ef293a62787b4510465fadbfe39ee4094").into(), | ||
| signature: eip2930::TransactionSignature::new( |
There was a problem hiding this comment.
Suggested change
| signature: eip2930::TransactionSignature::new( | |
| signature: eip1559::TransactionSignature::new( |
There was a problem hiding this comment.
Nevermind, just saw that it reuses eip2930::TransactionSignature.
There was a problem hiding this comment.
Maybe it could be in a common module that shares the common types like TransactionSignature, AccessList and TransactionAction, just to avoid confusion?
There was a problem hiding this comment.
The idea is to reuse unchanged struct from older hard forks to newer hard forks.
- We have legacy -> EIP-2930 -> EIP-1559 -> EIP-7702.
- In legacy, a
TransactionSignatureis defined. This becomeslegacy::TransactionSignature. - In EIP-2930, the format of
TransactionSignatureis changed, so we define aeip2930::TransactionSignature. - The format of signature is unchanged in EIP-1559 and EIP-7702, so in
eip1559andeip-7702mods, wepub use super::eip2930::TransactionSignature.
When the signature is invalid, the specification still asks that only the item is ignored, but not that decoding fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TransactionSignaturetype was designed to always maintain the invariant for EIP-2, but this wasn't later properly done for EIP-1559, EIP-2930, etc.