Skip to content

Conversation

justsmth
Copy link
Contributor

Issues

See:

Problem

The header files in the directories provided via CFLAGS can conflict with the specific headers needed for the project being built. The include files specified by the project should take precedence over those provided via CFLAGS.

Proposed change

A simple re-ordering of the arguments to add the specified include directories prior to those in CFLAGS.

Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it LGTM, I don't think it would break use of CFLAGS/CXXFLAGS

@NobodyXu NobodyXu merged commit 994dc90 into rust-lang:main Apr 24, 2024
@justsmth justsmth deleted the cflags-after-includes branch April 25, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants