Add DISABLE_TOKEN_CREATION flag
#11894
Merged
+51
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting this environment variable will cause crates.io to reject new API token creation requests with the error message set inside the environment variable. This can be useful to e.g. temporarily pause API token creation during ongoing phishing campaigns.
Turbo87
added
the
C-internal 🔧
pietroalbini
approved these changes
Sep 12, 2025
carols10cents
approved these changes
Sep 12, 2025
|
Can we add logging during the disablement period, to explicitly capture all attempts to create a token during the disabled period? |
|
Turbo87
commented
Sep 12, 2025
src/controllers/token.rs
Outdated
Comment on lines
132
to
135
| warn!( | ||
| "Blocked token creation for user `{}` (id: {}) due to disabled flag (token name: `{}`)", | ||
| user.gh_login, user.id, new.api_token.name | ||
| ); |
There was a problem hiding this comment.
@walterhpearce isn't that what we're doing here? 😅
There was a problem hiding this comment.
I missed it because I am not smart. Can we log the full request during this period? Headers + addresses.
There was a problem hiding this comment.
I've added the IP address and the headers, minus cookie and authorization header to not unnecessarily expose these in our logs.
walterhpearce
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting this environment variable will cause crates.io to reject new API token creation requests with the error message set inside the environment variable. This can be useful to e.g. temporarily pause API token creation during ongoing phishing campaigns.
Resolves #11892