Skip to content

Conversation

Dylan-DPC
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

GuillaumeGomez and others added 17 commits September 13, 2022 11:48
- .gitattributes: Mark minified javascript as binary to filter greps
- fix very minor punctuation typo
- diagnostic structs: derive on enum (rust-lang#1477)
- Update running tests with the new flags (rust-lang#1476)
- Rename typeck to hir_analysis (rust-lang#1475)
- fix typo and make paragraph consistent (rust-lang#1474)
- Update about-this-guide.md
- Link to the correct page in "about this guide"
- Update r-a config suggestions
- don't refer to the compile-time interpreter as "Miri" (rust-lang#1471)
- UPDATE - Diagnostic docs to reflect renamed traits and macros in rustc PR#101558
- Update mdbook and its extensions versions
- Remove unmaintained action
- Update some actions versions
- Fix some typos

Update motivated in large part by the most recent commit, to fix `git
grep`.
…piler-errors

Allow transmutes between the same types after erasing lifetimes

r? `@compiler-errors`  on the impl

fixes rust-lang#101081

See discussion in the issue and at https://rust-lang.zulipchat.com/#narrow/stream/326866-t-types.2Fnominated/topic/.23101081.3A.20Regression.20transmuting.20.60RwLockReadGuard.3CT.3A.20.3FSized.3E.E2.80.A6

I think this may need lang team signoff as its implications may go beyond the jurisdiction of T-types

I'll write up a proper summary later
…AGS, r=notriddle

Change default level of INVALID_HTML_TAGS to warning and stabilize it

Fixes of rust-lang#67799.

cc `@Nemo157`
r? `@notriddle`
Remove `mir::CastKind::Misc`

As discussed in rust-lang#97649 `mir::CastKind::Misc` is not clear, this PR addresses that by creating a new enum variant for every valid cast.

r? `@oli-obk`
sync thread_local key conditions exactly with what the macro uses

This makes the `cfg` in `mod.rs` syntactically the same as those in `local.rs`.

I don't think this should actually change anything, but seems better to be consistent?
I looked into this due to rust-lang#102549, but this PR would make it *less* likely that `__OsLocalKeyInner` is going to get provided, so this cannot help with that issue.

r? `@thomcc`
…d, r=compiler-errors

Remove `DefId` from some `SelectionCandidate` variants

They are both from `obligation.predicate.def_id()`, which do not need to be on the `SelectionCandidate`.

cc `@lcnr` `@compiler-errors`
… r=ehuss

Update rustc-dev-guide

- .gitattributes: Mark minified javascript as binary to filter greps
- fix very minor punctuation typo
- diagnostic structs: derive on enum (rust-lang#1477)
- Update running tests with the new flags (rust-lang#1476)
- Rename typeck to hir_analysis (rust-lang#1475)
- fix typo and make paragraph consistent (rust-lang#1474)
- Update about-this-guide.md
- Link to the correct page in "about this guide"
- Update r-a config suggestions
- don't refer to the compile-time interpreter as "Miri" (rust-lang#1471)
- UPDATE - Diagnostic docs to reflect renamed traits and macros in rustc PR#101558
- Update mdbook and its extensions versions
- Remove unmaintained action
- Update some actions versions
- Fix some typos

Update motivated in large part by the most recent commit, to fix `git
grep`.
…est-version, r=notriddle

Update browser UI test version

It added the possibility to concatenate strings and numbers and updated the `goto` command so it doesn't stand on its own anymore.

r? `@notriddle`
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 8, 2022
@Dylan-DPC
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Oct 8, 2022

📌 Commit bde0495 has been approved by Dylan-DPC

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 8, 2022
@bors
Copy link
Collaborator

bors commented Oct 8, 2022

⌛ Testing commit bde0495 with merge 5f34cbeb1428f4b8dbc27a17588bf68bcc34179d...

@rust-log-analyzer
Copy link
Collaborator

The job wasm32 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] gimli test:false 6.316
[RUSTC-TIMING] object test:false 7.477
warning: dropping unsupported crate type `dylib` for target `wasm32-unknown-emscripten`

error: variants `Unregistered`, `Registered` and `RunningOrHasRun` are never constructed
    |
913 |     enum DtorState {
    |          --------- variants in this enum
914 |         Unregistered,
914 |         Unregistered,
    |         ^^^^^^^^^^^^
915 |         Registered,
    |         ^^^^^^^^^^
916 |         RunningOrHasRun,
    |
    |
    = note: `DtorState` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
    = note: `-D dead-code` implied by `-D warnings`

error: fields `inner` and `dtor_state` are never read
    |
924 |     pub struct Key<T> {
    |                --- fields in this struct
...
...
933 |         inner: LazyKeyInner<T>,
    |         ^^^^^
...
937 |         dtor_state: Cell<DtorState>,

error: function `destroy_value` is never used
    --> library/std/src/thread/local.rs:1018:26
     |
     |
1018 |     unsafe extern "C" fn destroy_value<T>(ptr: *mut u8) {

error: associated function `new` is never used
   --> library/std/src/thread/local.rs:947:22
    |
    |
947 |         pub const fn new() -> Key<T> {

error: associated function `register_dtor` is never used
   --> library/std/src/thread/local.rs:954:23
    |
    |
954 |         pub unsafe fn register_dtor(a: *mut u8, dtor: unsafe extern "C" fn(*mut u8)) {

error: associated function `get` is never used
   --> library/std/src/thread/local.rs:960:23
    |
    |
960 |         pub unsafe fn get<F: FnOnce() -> T>(&self, init: F) -> Option<&'static T> {

error: associated function `try_initialize` is never used
   --> library/std/src/thread/local.rs:984:19
    |
    |
984 |         unsafe fn try_initialize<F: FnOnce() -> T>(&self, init: F) -> Option<&'static T> {

error: associated function `try_register_dtor` is never used
   --> library/std/src/thread/local.rs:997:19
    |
    |
997 |         unsafe fn try_register_dtor(&self) -> bool {
    |                   ^^^^^^^^^^^^^^^^^

error: function `register_dtor` is never used
  --> library/std/src/sys/unix/thread_local_dtor.rs:20:15
   |
20 | pub unsafe fn register_dtor(t: *mut u8, dtor: unsafe extern "C" fn(*mut u8)) {

[RUSTC-TIMING] std test:false 5.891
warning: `std` (lib) generated 1 warning
error: could not compile `std` due to 9 previous errors; 1 warning emitted

@bors
Copy link
Collaborator

bors commented Oct 8, 2022

💔 Test failed - checks-actions

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 8, 2022
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 8, 2022
@Dylan-DPC Dylan-DPC deleted the rollup-ncti0k0 branch October 8, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.