suggest is_empty for collections when casting to bool
#106896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This is definitely possible -- see |
Ezrashaw
force-pushed
the
str-cast-bool-emptyness
branch
from
9f915fb to
0229535
Compare
|
@compiler-errors I've applied your suggestions. Now we show this error if we can deref to a slice or |
Ezrashaw
force-pushed
the
str-cast-bool-emptyness
branch
from
0229535 to
42910a7
Compare
This comment has been minimized.
This comment has been minimized.
Ezrashaw
force-pushed
the
str-cast-bool-emptyness
branch
from
42910a7 to
92ced4a
Compare
|
@compiler-errors Forgot to re |
|
r? @compiler-errors @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 15, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#106888 (Add tidy check to ensure that rustdoc GUI tests start with a small description) - rust-lang#106896 (suggest `is_empty` for collections when casting to `bool`) - rust-lang#106900 (Fix regression in `unused_braces` with macros) - rust-lang#106906 (remove redundant clones) - rust-lang#106909 (Only suggest adding type param if path being resolved was a type) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106883
Matches on slices,
Stringandstr. It would be nice to do this with something likeDeref<Target=str>as well, but AFAIK it's not possible in this part of the compiler.