Skip to content

Mark const_trait_impl as active #87179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2021
Merged

Mark const_trait_impl as active #87179

merged 1 commit into from
Jul 16, 2021

Conversation

fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Jul 16, 2021 •
edited
Loading

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
From https://github.com/rust-lang/miri
 * branch              062cf07d98822beb4c5b1132f47b4397275f403a -> FETCH_HEAD
 * branch              06758c48bd7a77bb5aa43fc50cf344540ba5afef -> FETCH_HEAD
 * branch              dd7f545a69e4b720407e458bf4ade0b207bbf9ee -> FETCH_HEAD
fatal: remote error: upload-pack: not our ref 9ad6e5b8f68ee4bcd85886e50b8b0a70cbb91a52
Errors during submodule fetch:
##[error]Process completed with exit code 1.
Post job cleanup.

@hellow554
Copy link
Contributor

I would love to see some explanation or reference why this is not considered as "unstable" anymore. Maybe a github issue comment, a zulip thread or something else.
This seems a little bit out of context for me :/ (would make a good commit message 👍 )

@fee1-dead
Copy link
Member Author

I would love to see some explanation or reference why this is not considered as "unstable" anymore. Maybe a github issue comment, a zulip thread or something else.
This seems a little bit out of context for me :/ (would make a good commit message +1 )

I have edited the description.

@oli-obk
Copy link
Contributor

oli-obk commented Jul 16, 2021

CI keeps failing (I restarted it), though not out of any reason related to this PR. I'm just going to r+ it and let bors figure it out

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 16, 2021

📌 Commit 8841a42 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2021
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 16, 2021
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 16, 2021
@GuillaumeGomez
Rollup merge of rust-lang#87179 - fee1-dead:active-const-impl, r=oli-obk
64a73ab 
Mark `const_trait_impl` as active

See [this zulip thread](https://rust-lang.zulipchat.com/#narrow/stream/146212-t-compiler.2Fconst-eval/topic/implementation.20path.20for.20const.20trait.20impls).

r? `@oli-obk`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 16, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2021
@bors
Auto merge of rust-lang#87201 - GuillaumeGomez:rollup-4loi2q9, r=Guil…
74ef0c3 
…laumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#87107 (Loop over all opaque types instead of looking at just the first one with the same DefId)
 - rust-lang#87158 (Suggest full enum variant for local modules)
 - rust-lang#87174 (Stabilize `[T; N]::map()`)
 - rust-lang#87179 (Mark `const_trait_impl` as active)
 - rust-lang#87180 (feat(rustdoc): open sidebar menu when links inside it are focused)
 - rust-lang#87188 (Add GUI test for auto-hide-trait-implementations setting)
 - rust-lang#87200 (TAIT: Infer all inference variables in opaque type substitutions via InferCx)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4fbac29 into rust-lang:master Jul 16, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 16, 2021
@fee1-dead fee1-dead mentioned this pull request Jul 27, 2021
Merged
@fee1-dead fee1-dead deleted the active-const-impl branch May 12, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.55.0
Development

Successfully merging this pull request may close these issues.
7 participants
@fee1-dead @rust-log-analyzer @hellow554 @oli-obk @bors @rust-highfive @rustbot