various improvements resulting from reading Testing with CI #2593
+65
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieyouxu
reviewed
Sep 19, 2025
| specify its job name in a job pattern (explained below). | ||
|
|
||
| If you want to run custom CI job(s) in a try build and make sure that they pass all tests and do | ||
| If you want to run custom CI job in a try build and make sure that they pass all tests and do |
There was a problem hiding this comment.
Nit: the previous wording I find more accurate, because you can indeed run multiple custom CI jobs (in parallel)
Comment on lines
+280
to
+282
| Unfortunately, testing a single PR at a time, combined with our long CI (~2 | ||
| hours for a full run), means we can’t merge enough PRs in a single day, and a | ||
| single failure greatly impacts our throughput. The maximum number of |
There was a problem hiding this comment.
Nit: I find the previous "too many" wording is more accurate than "enough"
| [rust-toolstate]: https://rust-lang-nursery.github.io/rust-toolstate | ||
| [toolstate documentation]: https://forge.rust-lang.org/infra/toolstate.html | ||
|
|
||
| ## Public CI dashboard |
There was a problem hiding this comment.
Note: we should probably get rid of this entire section.
jieyouxu
added
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? ghost