Reanimate project and prepare for 2.0.0 #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the OAuth2 Token Endpoint Client library by upgrading to JDK 17 and updating all dependencies to their latest versions. The changes include replacing deprecated APIs, removing external dependencies in favor of JDK features, and migrating the build system to GitHub Actions with Maven Central publishing.
- Upgrade to JDK 17 and update all dependencies to latest versions
- Replace HttpURLConnection with JDK 11+ HttpClient for better performance and maintainability
- Replace ExpiringMap dependency with built-in ConcurrentHashMap implementation
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Updated dependencies, JDK version, and publishing configuration |
| TokenEndpointHttpClient.java | Replaced HttpURLConnection with modern HttpClient |
| InMemoryTokenCache.java | Replaced ExpiringMap with ConcurrentHashMap-based implementation |
| ClientAssertionJwtFactory.java | Updated to newer JJWT API methods |
| CertificateUtil.java | Replaced deprecated Base64 encoder with JDK standard |
| DigestUtil.java | Simplified using StandardCharsets and HexFormat |
| Multiple test files | Updated MockServer API usage and removed deprecated annotations |
src/main/java/com/scalepoint/oauth_token_client/InMemoryTokenCache.java
Outdated
Show resolved
Hide resolved
src/main/java/com/scalepoint/oauth_token_client/InMemoryTokenCache.java
Outdated
Show resolved
Hide resolved
src/main/java/com/scalepoint/oauth_token_client/InMemoryTokenCache.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes:
expiringmapis now replaced withConcurrentMapCo-authored with Claude and Copilot 😄