feat(k8s): rework kubeconfig handling #4137
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
k8s
jtherin
force-pushed
the
k8skubeconfig
branch
5 times, most recently
from
f967445 to
710551c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4137 +/- ##
==========================================
- Coverage 75.45% 70.89% -4.57%
==========================================
Files 202 294 +92
Lines 44323 66263 +21940
==========================================
+ Hits 33444 46975 +13531
- Misses 9653 17625 +7972
- Partials 1226 1663 +437 ☔ View full report in Codecov by Sentry. |
jtherin
force-pushed
the
k8skubeconfig
branch
2 times, most recently
from
62cda48 to
d4ab902
Compare
remyleone
reviewed
Nov 19, 2024
| AfterFunc: deleteCluster("Cluster"), | ||
| })) | ||
|
|
||
| // t.Run("copy-token", core.Test(&core.TestConfig{ |
There was a problem hiding this comment.
to avoid possible leaking of a token
There was a problem hiding this comment.
I'm not sure to follow, does this test needs to be uncommented, run and then commented again? Could you add documentation if it is the case?
Mia-Cross
force-pushed
the
k8skubeconfig
branch
from
07ffbaa to
e059a23
Compare
remyleone
reviewed
Sep 16, 2025
| KubeconfigAPIVersion = "v1" | ||
| KubeconfigKind = "Config" | ||
| installHint = `scaleway-cli (scw) is required to authenticate to the current cluster. | ||
| Installation instruction: https://github.com/scaleway/scaleway-cli#installation` |
There was a problem hiding this comment.
Could you add documentation in the README about the feature you are trying to use? It could be a dedicated tutorial as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.