Fix premature task status reporting for bash and Ansible tasks #3267
+30,793
−30,774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where bash and Ansible tasks were reporting Success or Failed status before the script execution and log processing were fully complete, leading to false positives and preventing manual task termination.
Problem
The issue occurred because
ShellApp.Run()
andAnsiblePlaybook
methods were callingcmd.Wait()
to wait for process completion but were not callingWaitLog()
to wait for log processing goroutines to finish. This created a race condition where:cmd.Wait()
returnsThis was particularly problematic for long-running commands like
rsync
where users would see the task marked as complete while the actual transfer was still in progress.Solution
Added
WaitLog()
calls aftercmd.Wait()
in:ShellApp.Run()
- for bash, Python, PowerShell and other shell-based tasksAnsiblePlaybook.RunPlaybook()
- for Ansible playbook executionAnsiblePlaybook.runCmd()
- for Ansible Galaxy and other ansible commandsThe fix ensures that task status is only reported as complete after both:
cmd.Wait()
returns)WaitLog()
returns)Note:
TerraformApp
already had the correct implementation withWaitLog()
calls, so no changes were needed there.Testing
Fixes #3234.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.