Skip to content

Conversation

spolti
Copy link
Member

@spolti spolti commented May 3, 2023

fixes #171

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

Special notes for reviewers:

Additional information (if needed):

@spolti spolti requested a review from ricardozanini as a code owner May 3, 2023 18:03
@github-actions github-actions bot added the source label May 3, 2023
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this happen only in SwitchState?

@spolti
Copy link
Member Author

spolti commented May 3, 2023

I didn't find it on another place.
I've tested with this workflow which have all the states
https://github.com/serverlessworkflow/sdk-go/blob/main/parser/testdata/workflows/greetings-v08-spec.sw.yaml

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@2ee5933). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage        ?   22.82%           
=======================================
  Files           ?       32           
  Lines           ?     2173           
  Branches        ?        0           
=======================================
  Hits            ?      496           
  Misses          ?     1641           
  Partials        ?       36           
Flag Coverage Δ
sdk-go 22.82% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ricardozanini ricardozanini merged commit 6278ce5 into serverlessworkflow:main May 4, 2023
@spolti spolti deleted the nullFields branch May 4, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty fields Marshaled as "field":null
3 participants