Skip to content

Conversation

matthias-pichler
Copy link
Collaborator

Signed-off-by: Matthias Pichler [email protected]

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

Closes #966

What this PR does:

It extracts the definition for the datetime descriptor and replaces nanosecods with seconds

Additional information:

Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from a little naming related comment.
Many thanks ❤️

Signed-off-by: Matthias Pichler <[email protected]>
@cdavernas cdavernas merged commit feb9ca9 into serverlessworkflow:main Aug 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename DateTimeDescriptor epochMillis and epochNanos
3 participants