feat(charts): support legend and tooltip type none #8082
+271
−259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxkaske is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mxkaske
commented
Sep 1, 2025
| @@ -1071,7 +1071,7 @@ const SheetContent = React.forwardRef< | |||
| {...props} | |||
| > | |||
| {children} | |||
| <SheetPrimitive.Close className="ring-offset-background focus:ring-ring data-[state=open]:bg-secondary absolute right-4 top-4 rounded-sm opacity-70 transition-opacity hover:opacity-100 focus:outline-none focus:ring-2 focus:ring-offset-2 disabled:pointer-events-none"> | |||
There was a problem hiding this comment.
@shadcn pnpm format:check failing due to the following class name reorder - should be ok now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recharts supports
legendType="none"andtooltipType="none"on different chart types. The following changes allow us to define which keys are supported inChartTooltipContentandChartLegendContent.Simply adding
payload.filter((item) => item.type !== "none")before mapping over it.The legendType is well documented whereas the tooltipType isn't (while still valid recharts property).