Skip to content

Add optional change callback to Recorder and RecorderCocoa #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 17, 2020
Merged

Add optional change callback to Recorder and RecorderCocoa #12

merged 5 commits into from
Jun 17, 2020

Conversation

gpoitch
Copy link
Contributor

@gpoitch gpoitch commented Jun 15, 2020 •
edited
Loading

Adds ability to register callback when a Recorder view's value is changed/removed.

KeyboardShortcuts.Recorder(for: .doSomething, onChange: { (shortcut: KeyboardShortcuts.Shortcut?) in
  print(shortcut)
})

Closes #11

@gpoitch gpoitch mentioned this pull request Jun 15, 2020
Closed
sindresorhus
sindresorhus requested changes Jun 16, 2020
View reviewed changes
@gpoitch gpoitch force-pushed the gp/recorder-callback branch from 05a205f to 00222ac Compare June 16, 2020 12:10
@sindresorhus sindresorhus changed the title Add optional callback for Recorder change Add optional change callback to Recorder and RecorderCocoa Jun 17, 2020
@sindresorhus sindresorhus merged commit 5cb615f into sindresorhus:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sindresorhus sindresorhus sindresorhus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recorder onChange callback
2 participants
@gpoitch @sindresorhus