Skip to content

Conversation

atellwu
Copy link
Contributor

@atellwu atellwu commented Apr 8, 2020

update DataChangeEventQueue: add log for onChange

@codecov-io
Copy link

Codecov Report

Merging #100 into master will decrease coverage by 0.10%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
- Coverage     62.58%   62.48%   -0.11%     
  Complexity       44       44              
============================================
  Files           429      429              
  Lines         15460    15464       +4     
  Branches       1489     1489              
============================================
- Hits           9676     9663      -13     
- Misses         4769     4787      +18     
+ Partials       1015     1014       -1     
Impacted Files Coverage Δ Complexity Δ
...server/data/change/event/DataChangeEventQueue.java 89.15% <40.00%> (-1.59%) 0.00 <0.00> (ø)
...sofa/registry/server/data/change/SnapshotData.java 90.00% <0.00%> (-10.00%) 0.00% <0.00%> (ø%)
...y/sofa/registry/server/data/change/ChangeData.java 58.33% <0.00%> (-8.34%) 0.00% <0.00%> (ø%)
...rver/session/node/service/DataNodeServiceImpl.java 60.55% <0.00%> (-6.67%) 0.00% <0.00%> (ø%)
...alipay/sofa/registry/remoting/bolt/BoltClient.java 58.00% <0.00%> (-2.00%) 0.00% <0.00%> (ø%)
...ver/session/bootstrap/SessionServerConfigBean.java 50.93% <0.00%> (-0.71%) 0.00% <0.00%> (ø%)
...a/registry/server/meta/store/DataStoreService.java 66.16% <0.00%> (-0.38%) 0.00% <0.00%> (ø%)
...ting/sessionserver/disconnect/DisconnectEvent.java 66.66% <0.00%> (+8.33%) 0.00% <0.00%> (ø%)
...r/session/scheduler/SessionThreadPoolExecutor.java 100.00% <0.00%> (+33.33%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b06d5c...8ba2d16. Read the comment docs.

@straybirdzls straybirdzls added this to the 5.4.3 milestone May 29, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #100 into master will increase coverage by 0.13%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
+ Coverage     62.44%   62.58%   +0.13%     
  Complexity       44       44              
============================================
  Files           429      429              
  Lines         15460    15464       +4     
  Branches       1489     1489              
============================================
+ Hits           9654     9678      +24     
+ Misses         4790     4766      -24     
- Partials       1016     1020       +4     
Impacted Files Coverage Δ Complexity Δ
...server/data/change/event/DataChangeEventQueue.java 89.15% <40.00%> (-1.59%) 0.00 <0.00> (ø)
...a/registry/server/meta/store/DataStoreService.java 66.16% <0.00%> (-0.38%) 0.00% <0.00%> (ø%)
...ver/session/bootstrap/SessionServerConfigBean.java 51.63% <0.00%> (+0.70%) 0.00% <0.00%> (ø%)
...alipay/sofa/registry/remoting/bolt/BoltClient.java 60.00% <0.00%> (+2.00%) 0.00% <0.00%> (ø%)
...y/sofa/registry/task/batcher/AcceptorExecutor.java 73.55% <0.00%> (+4.13%) 0.00% <0.00%> (ø%)
...rver/session/node/service/DataNodeServiceImpl.java 67.22% <0.00%> (+6.66%) 0.00% <0.00%> (ø%)
...ting/sessionserver/disconnect/DisconnectEvent.java 66.66% <0.00%> (+8.33%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16221f3...31c9c3d. Read the comment docs.

@straybirdzls straybirdzls merged commit a3b312c into sofastack:master May 29, 2020
nocvalight pushed a commit to nocvalight/sofa-registry that referenced this pull request Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants