Skip to content

Conversation

straybirdzls
Copy link
Member

No description provided.

@straybirdzls straybirdzls added this to the 5.4.3 milestone May 14, 2020
@straybirdzls straybirdzls changed the title Fix/session data ovverride clean Fix/session data override clean May 14, 2020
@straybirdzls straybirdzls requested a review from mamorukk May 15, 2020 06:03
@codecov-io
Copy link

Codecov Report

Merging #114 into master will decrease coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #114      +/-   ##
============================================
- Coverage     62.69%   62.55%   -0.15%     
  Complexity       44       44              
============================================
  Files           429      429              
  Lines         15460    15465       +5     
  Branches       1489     1490       +1     
============================================
- Hits           9693     9674      -19     
- Misses         4742     4771      +29     
+ Partials       1025     1020       -5     
Impacted Files Coverage Δ Complexity Δ
...egistry/server/session/store/SessionDataStore.java 58.55% <0.00%> (-0.54%) 0.00 <0.00> (ø)
...egistry/server/session/store/SessionInterests.java 78.36% <0.00%> (-1.15%) 0.00 <0.00> (ø)
...registry/server/session/store/SessionWatchers.java 29.89% <0.00%> (-0.32%) 0.00 <0.00> (ø)
...y/server/data/bootstrap/DataServerInitializer.java 58.33% <0.00%> (-25.01%) 0.00% <0.00%> (ø%)
...try/jraft/handler/RaftClientConnectionHandler.java 36.84% <0.00%> (-21.06%) 0.00% <0.00%> (ø%)
...registry/remoting/bolt/ConnectionEventAdapter.java 51.72% <0.00%> (-20.69%) 0.00% <0.00%> (ø%)
...try/jraft/handler/RaftServerConnectionHandler.java 40.00% <0.00%> (-20.00%) 0.00% <0.00%> (ø%)
...er/session/bootstrap/SessionServerInitializer.java 57.14% <0.00%> (-14.29%) 0.00% <0.00%> (ø%)
.../bootstrap/MetaServerInitializerConfiguration.java 57.14% <0.00%> (-14.29%) 0.00% <0.00%> (ø%)
...ipay/sofa/registry/jraft/bootstrap/RaftClient.java 40.00% <0.00%> (-3.34%) 0.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d1e3bb...e67cae5. Read the comment docs.

@straybirdzls straybirdzls requested a review from atellwu May 18, 2020 09:47
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2020

Codecov Report

Merging #114 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #114   +/-   ##
=========================================
  Coverage     62.55%   62.56%           
  Complexity       44       44           
=========================================
  Files           429      429           
  Lines         15464    15469    +5     
  Branches       1489     1490    +1     
=========================================
+ Hits           9674     9678    +4     
+ Misses         4769     4768    -1     
- Partials       1021     1023    +2     
Impacted Files Coverage Δ Complexity Δ
...egistry/server/session/store/SessionDataStore.java 58.55% <0.00%> (-0.54%) 0.00 <0.00> (ø)
...egistry/server/session/store/SessionInterests.java 78.36% <0.00%> (-1.15%) 0.00 <0.00> (ø)
...registry/server/session/store/SessionWatchers.java 29.89% <0.00%> (-0.32%) 0.00 <0.00> (ø)
...try/jraft/handler/RaftServerConnectionHandler.java 40.00% <0.00%> (-20.00%) 0.00% <0.00%> (ø%)
...registry/remoting/bolt/ConnectionEventAdapter.java 51.72% <0.00%> (-17.25%) 0.00% <0.00%> (ø%)
...ipay/sofa/registry/task/batcher/TaskExecutors.java 81.63% <0.00%> (-4.09%) 0.00% <0.00%> (ø%)
...y/sofa/registry/task/batcher/AcceptorExecutor.java 69.42% <0.00%> (-2.48%) 0.00% <0.00%> (ø%)
...alipay/sofa/registry/remoting/bolt/BoltServer.java 60.80% <0.00%> (-1.61%) 0.00% <0.00%> (ø%)
...ver/session/bootstrap/SessionServerConfigBean.java 51.63% <0.00%> (+0.70%) 0.00% <0.00%> (ø%)
...alipay/sofa/registry/remoting/bolt/BoltClient.java 60.00% <0.00%> (+2.00%) 0.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b312c...21dd2d2. Read the comment docs.

@dzdx dzdx merged commit bea8df7 into sofastack:master Aug 23, 2020
nocvalight pushed a commit to nocvalight/sofa-registry that referenced this pull request Aug 23, 2020
* chore: update version to 5.4.3-SNAPSHOT

* fix: when client re-connect happened before client-off, session will have dirty connectIndex
dzdx pushed a commit that referenced this pull request Dec 13, 2021
* chore: update version to 5.4.3-SNAPSHOT

* fix: when client re-connect happened before client-off, session will have dirty connectIndex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants