Skip to content

Conversation

thinke5
Copy link

@thinke5 thinke5 commented Mar 27, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

What is the current behavior?

api route return 404

What is the new behavior?

api route return 200

Other information

none

Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: b135567

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Mar 27, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit b135567
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/68b0d69c9971d60008cd1dec
😎 Deploy Preview https://deploy-preview-1871--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@birkskyum
Copy link
Member

Changeset missing


// api
const match = matchAPIRoute(new URL(event.request.url).pathname, event.request.method);
const match = matchAPIRoute(event.nativeEvent.path, event.request.method);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The event.nativeEvent.path includes the query string 1 and the matchAPIRoute won't work in this case.

Maybe:

const [pathname] = event.nativeEvent.path.split("?", 2);
const match = matchAPIRoute(pathname, event.request.method);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so your saying this won't work? @thislight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: Configuring server.baseURL will make the api route inaccessible
5 participants