Remove save_bsub parameter from stage 2 pipelines

[stscijgbot-jp]

Issue JP-4106 was created on JIRA by Melanie Clarke:

There is a "save_bsub" parameter for calwebb_image2 and calwebb_spec2 that has some confusing behavior.  It defaults to False, but is used only if set to True.  If it is True, then save_results for the bkg_subtract step is also set to True; if it is False, the save_results parameter is used as is (from the user input, CRDS parameters, or software defaults for the step).

Since save_results already exists as an option for every step, and since it will be turned on for the bkg_subtract step by default for some modes after JP-3673, I suggest we remove the save_bsub option from the pipeline parameters.

[stscijgbot-jp]

Comment by Bryan Hilbert on JIRA:

The existence of save_bsub definitely confused me when I was creating a parameter reference file for the background subtraction step. I agree that for consistency with the other pipeline steps, it would be best to remove this.

[stscijgbot-jp]

Comment by David Law on JIRA:

Hm, that sounds like a confusing conflict that would be good to clean up.  Tagging Ned Molter Rachel Plesha as well since this related to all of the work on https://jira.stsci.edu/browse/JP-3673

[stscijgbot-jp]

Comment by Rachel Plesha on JIRA:

In CRDS-1012, CRDS-1013, & CRDS-1014, the parameter reference files use "save_results", so we should be good to go with this.

 

Gael Noirot tagging you for awareness since I think you've used this parameter before. 

[stscijgbot-jp]

Comment by David Law on JIRA:

Adding this to our list of WFSS issues for 12.1 then.  We'd need to check that no existing parameter reference files set save_bsub though to avoid a crash when the option is removed.  I don't think that should be the case, as such files aren't in MAST that I know of, but we should check.