Why -test.v flag does not work?

[urbainleverrier]

I want to use pflag package with testing. Such as...

package main

import (
  "fmt"
  "os"
  "testing"
  goflag "flag"
  "github.com/spf13/pflag"
)

var ip *int = pflag.Int("flagname", 1234, "help message for flagname")

func TestMain(m *testing.M) {
  pflag.CommandLine.AddGoFlagSet(goflag.CommandLine)
  pflag.Parse()
  os.Exit(m.Run())
}

func TestHello(t *testing.T) {
  fmt.Printf("-test.v is specified %t\n", testing.Verbose()) // -> -test.v is specified false
  if *ip != 5678 {
    t.Fatal("not good.")
  }
  t.Log("called") // -> No output
}

Which results in:

$ go test main_test.go --flagname 5678 -v
-test.v is specified false
PASS
ok  	command-line-arguments	0.006s

Could you give me some advice?

Go version: 1.13.6
pflag version: v1.0.5

[urbainleverrier]

From https://github.com/spf13/pflag/blob/v1.0.5/flag.go#L1010-L1012,
I understood pflag intends to ignore test flags.

The simple solution is adding to my code.

  var testFlags []string
  for _, f := range os.Args[1:] {
    if strings.HasPrefix(f, "-test.") {
      testFlags = append(testFlags, f)
    }
  }
  goflag.CommandLine.Parse(testFlags)

Or are there any better solutions?

[urbainleverrier]

related:

• adds check to see if command name and os.Args[0] is the same before... cobra#155 (comment)
• When using "go test -v", I get "unknown shorthand flag: 't' in -test.v=true" #65