Reactive mongo #2044
Merged
Reactive mongo #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
There was a problem hiding this comment.
There might be a conflict between sync and async driver config, the tests are failing with:
org.springframework.beans.BeanInstantiationException: Failed to instantiate [com.mongodb.client.MongoClient]: Factory method 'mongo' threw exception; nested exception is java.lang.IllegalArgumentException: The contextProvider must be an instance of com.mongodb.client.SynchronousContextProvider when using the synchronous driver
| import org.bson.BsonDocument; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.mockito.BDDMockito; | ||
| import org.mockito.Mockito; |
There was a problem hiding this comment.
Should we replace BDDMockito and BDDAssertions whenever we see them?
| childSpanBuilder.remoteIpAndPort(socketAddress.getAddress().getHostAddress(), socketAddress.getPort()); | ||
| } | ||
| catch (MongoSocketException ignored) { | ||
|
|
There was a problem hiding this comment.
Shouldn't we emit a DEBUG log here?
| private final Map<Object, Object> map = new ConcurrentHashMap<>(); | ||
|
|
||
| TraceRequestContext(ContextView context) { | ||
| context.stream().forEach(entry -> map.put(entry.getKey(), entry.getValue())); |
There was a problem hiding this comment.
How about creating the map here:
Suggested change
| context.stream().forEach(entry -> map.put(entry.getKey(), entry.getValue())); | |
| map = context.stream().collect(Collectors.toMap(entry::getKey, entry::getValue)); |
marcingrzejszczak
force-pushed
the
reactive_mongo
branch
from
4dfb1f5 to
a4616be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the sample spring-cloud-samples/spring-cloud-sleuth-samples#15