Skip to content

Optimize parameter matching in TableMetaDataContext #35417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −7
Open

Optimize parameter matching in TableMetaDataContext #35417

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11892fb
Optimize parameter matching in TableMetaDataContext
belljun3395 Sep 4, 2025
cdb149b
Refactor parameter matching to use LinkedCaseInsensitiveMap for impro…
belljun3395 Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/TableMetaDataContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
import org.springframework.jdbc.support.JdbcUtils;
import org.springframework.util.Assert;
import org.springframework.util.CollectionUtils;
import org.springframework.util.LinkedCaseInsensitiveMap;
import org.springframework.util.StringUtils;

/**
Expand Down Expand Up @@ -265,18 +266,17 @@ public List<Object> matchInParameterValuesWithInsertColumns(SqlParameterSource p
* @param inParameters the parameter names and values
*/
public List<Object> matchInParameterValuesWithInsertColumns(Map<String, ?> inParameters) {
List<Object> values = new ArrayList<>(inParameters.size());
List<Object> values = new ArrayList<>(this.tableColumns.size());

LinkedCaseInsensitiveMap<Object> caseInsensitiveLookup = new LinkedCaseInsensitiveMap<>(inParameters.size());
caseInsensitiveLookup.putAll(inParameters);

for (String column : this.tableColumns) {
Object value = inParameters.get(column);
if (value == null) {
value = inParameters.get(column.toLowerCase(Locale.ROOT));
if (value == null) {
for (Map.Entry<String, ?> entry : inParameters.entrySet()) {
if (column.equalsIgnoreCase(entry.getKey())) {
value = entry.getValue();
break;
}
}
value = caseInsensitiveLookup.get(column);
}
}
values.add(value);
Expand Down