GH-4035: Clarify docs on default non-blocking retry setup #4058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rheeri
force-pushed
the
gh-4035
branch
3 times, most recently
from
6817afa to
9bbd2f2
Compare
sobychacko
requested changes
Aug 25, 2025
There was a problem hiding this comment.
@rheeri Just some minor polishing comments. Could you take care of it and update the PR? Thanks!
spring-kafka-docs/src/main/antora/modules/ROOT/pages/retrytopic/retry-config.adoc
Outdated
Show resolved
Hide resolved
spring-kafka-docs/src/main/antora/modules/ROOT/pages/retrytopic/retry-config.adoc
Outdated
Show resolved
Hide resolved
spring-kafka-docs/src/main/antora/modules/ROOT/pages/retrytopic/retry-config.adoc
Outdated
Show resolved
Hide resolved
|
@sobychacko Thanks for the feedback! Updated the doc to reflect your suggestions (one sentence per line). |
sobychacko
approved these changes
Aug 26, 2025
|
@rheeri, in the DCO signing, could you please use your real name in English before the email? Thanks! |
Signed-off-by: Yuri Lee <[email protected]>
Signed-off-by: Yuri Lee <[email protected]>
|
@sobychacko Updated the DCO sign-off to use my English name. Thanks! |
spring-builds
pushed a commit
that referenced
this pull request
Aug 27, 2025
* Docs: clarify default non-blocking retry setup * Docs: format asciidoc files to one sentence per line Fixes #4035 Signed-off-by: Yuri Lee <[email protected]> (cherry picked from commit 649d483)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@EnableKafkaRetryTopic(or extendingRetryTopicConfigurationSupport) is required for default usage.@RetryableTopicalone is sufficient to provision retry/DLT topics and their consumers with default settings.Fixes #4035