Skip to content

Fix forRemoval deprecations #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025
Merged

Fix forRemoval deprecations #1166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions gradle/java-conventions.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ project.afterEvaluate {
tasks.withType(JavaCompile).configureEach {
options.encoding = "UTF-8"
options.compilerArgs.add("-parameters")
// TODO add this back in once we have removed deprecations
//options.compilerArgs.addAll(["-Werror", "-Xlint:unchecked", "-Xlint:rawtypes", "-Xlint:varargs"]);
options.compilerArgs.addAll(["-Werror", "-Xlint:unchecked", "-Xlint:rawtypes", "-Xlint:varargs"]);
options.release.set(17)
}
}
Expand Down
14 changes: 5 additions & 9 deletions ...ive/src/main/java/org/springframework/pulsar/reactive/aot/ReactivePulsarRuntimeHints.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,17 +63,15 @@ public void registerHints(RuntimeHints hints, @Nullable ClassLoader classLoader)
SecretsSerializer.class, NioSocketChannel.class, AbstractByteBufAllocator.class,
NioDatagramChannel.class, PulsarAdminBuilderImpl.class, OffloadProcessStatusImpl.class,
Commands.class, ReferenceCountUtil.class)
.forEach(type -> reflectionHints.registerType(type,
builder -> builder.withMembers(MemberCategory.INVOKE_DECLARED_CONSTRUCTORS,
MemberCategory.INVOKE_DECLARED_METHODS, MemberCategory.INTROSPECT_PUBLIC_METHODS)));
.forEach(type -> reflectionHints.registerType(type, builder -> builder
.withMembers(MemberCategory.INVOKE_DECLARED_CONSTRUCTORS, MemberCategory.INVOKE_DECLARED_METHODS)));

// In addition to the above member category levels, these components need field
// and declared class level access.
Stream.of(ClientConfigurationData.class, ConsumerConfigurationData.class, ProducerConfigurationData.class)
.forEach(type -> reflectionHints.registerType(type,
builder -> builder.withMembers(MemberCategory.INVOKE_DECLARED_CONSTRUCTORS,
MemberCategory.INVOKE_DECLARED_METHODS, MemberCategory.INTROSPECT_PUBLIC_METHODS,
MemberCategory.DECLARED_CLASSES, MemberCategory.DECLARED_FIELDS)));
MemberCategory.INVOKE_DECLARED_METHODS, MemberCategory.ACCESS_DECLARED_FIELDS)));

// These are inaccessible interfaces/classes in a normal scenario, thus using the
// String version, and we need field level access in them.
Expand All @@ -88,7 +86,7 @@ public void registerHints(RuntimeHints hints, @Nullable ClassLoader classLoader)
"org.apache.pulsar.shade.io.netty.util.internal.shaded.org.jctools.queues.unpadded.MpscUnpaddedArrayQueueProducerIndexField",
"org.apache.pulsar.shade.io.netty.util.internal.shaded.org.jctools.queues.unpadded.MpscUnpaddedArrayQueueProducerLimitField")
.forEach(typeName -> reflectionHints.registerTypeIfPresent(classLoader, typeName,
MemberCategory.DECLARED_FIELDS));
MemberCategory.ACCESS_DECLARED_FIELDS));

// @formatter:off
Stream.of(
Expand Down Expand Up @@ -150,9 +148,7 @@ public void registerHints(RuntimeHints hints, @Nullable ClassLoader classLoader)
MemberCategory.INVOKE_DECLARED_CONSTRUCTORS,
MemberCategory.INVOKE_PUBLIC_METHODS,
MemberCategory.INVOKE_DECLARED_METHODS,
MemberCategory.INTROSPECT_PUBLIC_METHODS,
MemberCategory.DECLARED_CLASSES,
MemberCategory.DECLARED_FIELDS)));
MemberCategory.ACCESS_DECLARED_FIELDS)));
reflectionHints.registerField(ReflectionUtils.findField(Thread.class, "threadLocalRandomProbe"));

// @formatter:on
Expand Down
11 changes: 4 additions & 7 deletions spring-pulsar/src/main/java/org/springframework/pulsar/aot/PulsarRuntimeHints.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,8 @@ public void registerHints(RuntimeHints hints, @Nullable ClassLoader classLoader)
.of(HashSet.class, LinkedHashMap.class, TreeMap.class, Authentication.class,
AuthenticationDataProvider.class, SecretsSerializer.class, PulsarAdminBuilderImpl.class,
OffloadProcessStatusImpl.class, Commands.class)
.forEach(type -> reflectionHints.registerType(type,
builder -> builder.withMembers(MemberCategory.INVOKE_DECLARED_CONSTRUCTORS,
MemberCategory.INVOKE_DECLARED_METHODS, MemberCategory.INTROSPECT_PUBLIC_METHODS)));
.forEach(type -> reflectionHints.registerType(type, builder -> builder
.withMembers(MemberCategory.INVOKE_DECLARED_CONSTRUCTORS, MemberCategory.INVOKE_DECLARED_METHODS)));

// In addition to the above member category levels, these components need field
// and declared class level access.
Expand All @@ -69,8 +68,7 @@ public void registerHints(RuntimeHints hints, @Nullable ClassLoader classLoader)
ListTopicsOptions.class)
.forEach(type -> reflectionHints.registerType(type,
builder -> builder.withMembers(MemberCategory.INVOKE_DECLARED_CONSTRUCTORS,
MemberCategory.INVOKE_DECLARED_METHODS, MemberCategory.INTROSPECT_PUBLIC_METHODS,
MemberCategory.DECLARED_CLASSES, MemberCategory.DECLARED_FIELDS)));
MemberCategory.INVOKE_DECLARED_METHODS, MemberCategory.ACCESS_DECLARED_FIELDS)));

// @formatter:off
// These are shaded classes and other inaccessible interfaces/classes (thus using
Expand Down Expand Up @@ -201,8 +199,7 @@ public void registerHints(RuntimeHints hints, @Nullable ClassLoader classLoader)
.forEach(type -> reflectionHints.registerTypeIfPresent(classLoader, type,
builder -> builder.withMembers(MemberCategory.INVOKE_DECLARED_CONSTRUCTORS,
MemberCategory.INVOKE_PUBLIC_METHODS, MemberCategory.INVOKE_DECLARED_METHODS,
MemberCategory.INTROSPECT_PUBLIC_METHODS, MemberCategory.DECLARED_CLASSES,
MemberCategory.DECLARED_FIELDS)));
MemberCategory.ACCESS_DECLARED_FIELDS)));
// @formatter:on

// Registering JDK dynamic proxies for these interfaces. Since the Connection
Expand Down