Skip to content

Cleanup exclusions #1223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged

Cleanup exclusions #1223

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b826ca
Remove no longer needed exclusions from pulsar-client-all
onobc Aug 14, 2025
593e4df
Exclude commons-logging from pulsar-client-all
onobc Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions spring-pulsar/spring-pulsar.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@ apply from: '../gradle/proto-conventions.gradle'
dependencies {
api 'io.micrometer:micrometer-observation'
api (libs.pulsar.client.all) {
exclude group: 'org.apache.logging.log4j'
exclude group: 'commons-logging', module: 'commons-logging'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @snicoll,

You should be able to remove the numerous exclusions in spring-projects/spring-boot@ad8ca01 once this is merged.

Note

The spring-pulsar-reactive module also leverages these exclusions in spring-pulsar

exclude group: 'javax.validation', module: 'validation-api'
exclude group: 'com.google.protobuf', module: 'protobuf-java'
}
api 'org.springframework:spring-context'
api 'org.springframework:spring-messaging'
Expand Down