Skip to content

Eliminate unnecessary sessionRepository::findById #1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Eliminate unnecessary sessionRepository::findById #1909

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Aug 31, 2021

It is an obvious fix.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 31, 2021
@eleftherias eleftherias self-assigned this Sep 2, 2021
@eleftherias
Copy link
Contributor

Hi @quaff, this is a duplicate of gh-1732.
Please use the search functionality to check for existing issues before opening a new issue or pull request.

@eleftherias eleftherias closed this Sep 2, 2021
@eleftherias eleftherias added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 2, 2021
@quaff
Copy link
Contributor Author

quaff commented Sep 2, 2021

@eleftherias This one is more simple and safe than that one.

@quaff quaff mentioned this pull request Sep 3, 2021
Closed
@quaff
Copy link
Contributor Author

quaff commented Sep 10, 2021

@vpavic Could you take a look at this?

@vpavic vpavic mentioned this pull request Aug 26, 2022
Closed
@rwinch rwinch added type: enhancement A general enhancement in: core and removed status: duplicate A duplicate of another issue labels Oct 18, 2022
@rwinch rwinch assigned rwinch and unassigned eleftherias Oct 18, 2022
@rwinch rwinch added this to the 3.0.0-RC1 milestone Oct 18, 2022
@vpavic
Copy link
Contributor

vpavic commented Oct 18, 2022

After a closer review, we've decided to do this change in 3.0.0-RC1 as it is an elegant way of removing that extra round trip to session store and fetch the session. Thanks for the contribution @quaff.

@rwinch rwinch removed this from the 3.0.0-RC1 milestone Oct 18, 2022
@rwinch rwinch added the status: duplicate A duplicate of another issue label Oct 18, 2022
@rwinch
Copy link
Member

rwinch commented Oct 18, 2022

Closed this via #2194 which contained polish for checkstyle

@vpavic vpavic mentioned this pull request Oct 19, 2022
Closed
@vpavic vpavic mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwinch rwinch

Labels
in: core status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@quaff @eleftherias @vpavic @rwinch @spring-projects-issues