CacheStorage (2/3) #569
Open
CacheStorage (2/3) #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxg-square
force-pushed
the
maxg/cache_2_envcache
branch
from
5d53aa4 to
84fe9bb
Compare
* maxg/cache_1_equivalency: Release 6.3.0 Assert in debug mode when large content viewer is not placed inside an interaction container Expose largeContentViewerInteraction on LargeContentViewer backing view via protocol Stopped installing xcodes in GitHub Actions file chore: Release 6.2.0 Support accessibility large content viewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2/3 for caching changes.
Big-picture PR here: #587
Design doc: https://docs.google.com/document/d/1CLhFbzZGbEKgvZTUwLuGbFY-rfZNJVTi6f3PkoZT9qI/edit?usp=sharing
CacheStorage, an object which hangs off ofEnvironment.CacheStoragehas a similar API toEnvironment, with consumers declaring their types and default values by declaring aCacheKey.Environmentwhich do not participate inContextuallyEquivalentchecks.EnvironmentSnapshot, which is a snapshot of anEnvironmentthat holds a subset of its storage, and is used byValidatingCache.ValidatingCache, which allows a key to be set with a value that's associated with a validation function.EnvironmentValidatingCacheandEnvironmentAndValueValidatingCache, which are simplified interfaces toValidatingCachewhich provide additional comparison ofEnvironmentcontexts.