Skip to content

test: Add an integration test for LDAP with TLS #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 29, 2025
Merged

test: Add an integration test for LDAP with TLS #21

merged 8 commits into from
Aug 29, 2025

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Aug 9, 2025 •
edited
Loading

Description

Add an integration test for LDAP with TLS

Part of #1

Definition of Done Checklist

Author

  • Changes are OpenShift compatible
  • Integration tests passed (for non trivial changes)

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@siegfriedweber siegfriedweber self-assigned this Aug 9, 2025
@siegfriedweber siegfriedweber mentioned this pull request Aug 9, 2025
Open
28 tasks
@siegfriedweber siegfriedweber marked this pull request as ready for review August 29, 2025 09:35
@siegfriedweber siegfriedweber requested a review from razvan August 29, 2025 09:35
razvan
razvan previously approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you tested already. The suggestions are optional.

@siegfriedweber siegfriedweber requested a review from razvan August 29, 2025 10:59
razvan
razvan approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@siegfriedweber siegfriedweber added this pull request to the merge queue Aug 29, 2025
Merged via the queue into main with commit 00f7010 Aug 29, 2025
15 checks passed
@siegfriedweber siegfriedweber deleted the test/ldap branch August 29, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvan razvan razvan approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siegfriedweber @razvan