Skip to content

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented Sep 19, 2025

Description

Part of stackabletech/issues#763

Note

These changes aren't exactly consistent with listener-operator changes from stackabletech/listener-operator#334, but are a step towards consistency, and make it easier should we decide to split secret-operator into a CSI Provisioner Deployment and CSI Node Driver DaemonSet.

Helm Values changes

Caution

The original values are no longer valid.

  • image.repository has been moved to secretOperator.image.repository.
  • image.tag has been moved to secretOperator.image.tag.
  • image.pullPolicy has been moved to secretOperator.image.pullPolicy.
  • csiProvisioner values have been moved to externalProvisioner.
  • csiNodeDriverRegistrar values have been moved to nodeDriverRegistrar.
  • node.driver values have been moved to secretOperator.
  • securityContext values have been moved to secretOperator.securityContext.

Tip

In addition, the following new value is available.
This is part of stackabletech/issues#765.

  • priorityClassName
diff --git a/deploy/helm/secret-operator/values.yaml b/deploy/helm/secret-operator/values.yaml
index c920d3b..3d8c6dc 100644
--- a/deploy/helm/secret-operator/values.yaml
+++ b/deploy/helm/secret-operator/values.yaml
@@ -1,11 +1,9 @@
 # Default values for secret-operator.
 ---
 image:
-  repository: oci.stackable.tech/sdp/secret-operator
-  pullPolicy: IfNotPresent
   pullSecrets: []
 
-csiProvisioner:
+externalProvisioner:
   image:
     repository: oci.stackable.tech/sdp/sig-storage/csi-provisioner
     tag: v5.2.0
@@ -17,7 +15,7 @@ csiProvisioner:
     limits:
       cpu: 100m
       memory: 128Mi
-csiNodeDriverRegistrar:
+nodeDriverRegistrar:
   image:
     repository: oci.stackable.tech/sdp/sig-storage/csi-node-driver-registrar
     tag: v2.13.0
@@ -30,16 +28,33 @@ csiNodeDriverRegistrar:
       cpu: 100m
       memory: 128Mi
 
-node:
-  driver:
-    # Resources of the secret-operator container itself
-    resources:
-      limits:
-        cpu: 100m
-        memory: 128Mi
-      requests:
-        cpu: 100m
-        memory: 128Mi
+secretOperator:
+  image:
+    repository: oci.stackable.tech/sdp/secret-operator
+    # tag: 0.0.0-dev
+    pullPolicy: IfNotPresent
+  # Resources of the secret-operator container itself
+  resources:
+    limits:
+      cpu: 100m
+      memory: 128Mi
+    requests:
+      cpu: 100m
+      memory: 128Mi
+
+  securityContext:
+    # secret-operator requires root permissions
+    runAsUser: 0
+    # It is strongly recommended to run secret-operator as a privileged container, since
+    # it enables additional protections for the secret contents.
+    # Unprivileged mode is EXPERIMENTAL and requires manual migration for an existing cluster.
+    privileged: true
+    # capabilities:
+    #   drop:
+    #   - ALL
+    # readOnlyRootFilesystem: true
+    # runAsNonRoot: true
+    # runAsUser: 1000
 
 nameOverride: ""
 fullnameOverride: ""
@@ -62,26 +77,14 @@ labels:
 podSecurityContext: {}
   # fsGroup: 2000
 
-securityContext:
-  # secret-operator requires root permissions
-  runAsUser: 0
-  # It is strongly recommended to run secret-operator as a privileged container, since
-  # it enables additional protections for the secret contents.
-  # Unprivileged mode is EXPERIMENTAL and requires manual migration for an existing cluster.
-  privileged: true
-  # capabilities:
-  #   drop:
-  #   - ALL
-  # readOnlyRootFilesystem: true
-  # runAsNonRoot: true
-  # runAsUser: 1000
-
 nodeSelector: {}
 
 tolerations: []
 
 affinity: {}
 
+# priorityClassName: ...
+
 # When running on a non-default Kubernetes cluster domain, the cluster domain can be configured here.
 # See the https://docs.stackable.tech/home/stable/guides/kubernetes-cluster-domain guide for details.
 # kubernetesClusterDomain: my-cluster.local

…tener-operator value changes

Part of stackabletech/issues#763

NOTE: These aren't exactly consistent with listener-operator changes from stackabletech/listener-operator#334, but are a step towards consistency, and make it easier should we decide to split secret-operator into a CSI Provisioner Deployment and CSI Node Driver DaemonSet.
@NickLarsenNZ NickLarsenNZ self-assigned this Sep 19, 2025
@NickLarsenNZ NickLarsenNZ added release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. scheduled-for/25.11.0 labels Sep 19, 2025
@NickLarsenNZ
Copy link
Member Author

Release Notes

Refer to: stackabletech/issues#763 (comment)

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Sep 22, 2025
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Sep 22, 2025
Merged via the queue into main with commit ee7e164 Sep 22, 2025
17 checks passed
@NickLarsenNZ NickLarsenNZ deleted the feat/csi-driver-helm-values branch September 22, 2025 06:26
@NickLarsenNZ NickLarsenNZ removed the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Sep 22, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants