Skip to content

Conversation

oliversalzburg
Copy link
Member

Includes JSON3 in the polyfill version
Fixes #133

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long.
Missing semicolon.
Expected an identifier and instead saw '=='.
Expected an operator and instead saw 'typeof'.
Expected an assignment or function call and instead saw an expression.
Wrap an immediate function invocation in parens to assist the reader in understanding that the expression is the result of a function, and not the function itself.
'e' is already defined.
't' is already defined.
Possible strict violation.
Expected '{' and instead saw 'throw'.
Expected '{' and instead saw 'return'.
'i' is already defined.
Use '!==' to compare with 'null'.
Too many errors. (50% scanned).

@oliversalzburg
Copy link
Member Author

@eriwen Can we exclude dist from HoundCI checks? Also, do you know what the problem is with Travis?

@eriwen
Copy link
Member

eriwen commented Oct 16, 2015

@oliversalzburg Looks like we can exclude files from Hound by adding a .jshintignore file with the following content:

dist/*

I'm not sure about Travis. It works on master and we haven't made changes. Maybe something is wrong with the PR-specific config somehow...

@eriwen
Copy link
Member

eriwen commented Oct 16, 2015

Also, this looks good except for the one thing; thank you!

gulpfile.js Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go in polyfills

@oliversalzburg
Copy link
Member Author

  • Fixed the gulp build (wow, what a mistake)
  • Added .jshintignore
  • Fixed the test

Includes JSON3 in the polyfill version
Fixes #133

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can that still be too long? O_o

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm.. I'm guessing the default line length limit is 80.

Sorry about the annoying Hound stuff; don't worry about this kinda thing. I may just disable it since JSHint is part of the build anyway.

@eriwen
Copy link
Member

eriwen commented Oct 17, 2015

Looks good! :shipit:

oliversalzburg added a commit that referenced this pull request Oct 18, 2015
@oliversalzburg oliversalzburg merged commit 2053cd7 into stacktracejs:master Oct 18, 2015
@oliversalzburg oliversalzburg deleted the fix/report branch October 18, 2015 14:01
eriwen pushed a commit that referenced this pull request Apr 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants