feat(server): add bool operator and end() api #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frederic Pillon <[email protected]>
Signed-off-by: Frederic Pillon <[email protected]>
Fixes stm32duino#73. Signed-off-by: Frederic Pillon <[email protected]>
Fixes stm32duino#73. Signed-off-by: Frederic Pillon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bool operator:
https://www.arduino.cc/reference/en/libraries/ethernet/ifserver/
end():Not officially documented. Pay attention, when
end()is called, the socket is not close immediately. The tcp connection will come intoTCP_WAIT, after few minutes (~2 minutes) the connection will close completely and free the socket.So calling
begin()during this time frame after theend()will silently failed and have to check thanks the bool operator if the server is ready or not. If not then call againbegin().For
TCP_WAITref: https://github.com/stm32duino/LwIP/blob/4de72d4b92ebf1ac5ce5efe7c331c0af6d52cca3/src/core/tcp.c#L1446C11-L1446C11Fixes #73.