Skip to content
This repository was archived by the owner on Feb 2, 2018. It is now read-only.

Conversation

bajtos
Copy link
Contributor

@bajtos bajtos commented Sep 22, 2017

This pull request takes parts of #1 and makes the following changes:

  • remove tsconfig.common.json, it's not needed in a single-package repo
  • remove "exclude" from tsconfig, not needed
  • add typescript as a dependency, configured build - slightly differently than in loopback-next, I'd like to try out a better setup
  • add linting step
  • add top-level index.js, src/index.ts
  • add simple smoke test, configure mocha
  • add VSCode project config
    • tsc-watch task + problem matcher
    • test + lint task
  • explicitly list files to include in the npm package
  • add DEVELOPING.md describing the dev setup
    • Node.js 8.x or newer only
    • VSCode + extensions: Prettier, tslint
    • command+shift+b to start typescript watch/build in background
    • command+shift+t to run the tests and lint the code

@virkt25 @kjdelisle PTAL

@bajtos bajtos added this to the Sprint 45 milestone Sep 22, 2017
@bajtos bajtos self-assigned this Sep 22, 2017
@bajtos bajtos requested review from kjdelisle and virkt25 September 22, 2017 12:05
@bajtos
Copy link
Contributor Author

bajtos commented Sep 22, 2017

connect to loopbackio/loopback-next#525

Copy link

@kjdelisle kjdelisle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor nits, otherwise LGTM

README.md Outdated

Starting point to create a variety of extensions for loopback-next.
A starter project to create extensions for loopback-next

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lost your trailing period here.

tslint.json Outdated
]
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an extra newline and the indentation was off too, I reformatted the code in vim.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants