♻️(frontend) search on all docs if no children #1184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
refacto/search-no-child
branch
from
9d28147 to
1d8d6d3
Compare
lunika
reviewed
Jul 21, 2025
| @@ -12,10 +13,10 @@ import { useLeftPanelStore } from '../stores'; | |||
| import { LeftPanelHeaderButton } from './LeftPanelHeaderButton'; | |||
|
|
|||
| export const LeftPanelHeader = ({ children }: PropsWithChildren) => { | |||
| const { currentDoc } = useDocStore(); | |||
| const isDoc = !!currentDoc; | |||
There was a problem hiding this comment.
isDoc is probably not describing enough what is the purpose of this variable.
There was a problem hiding this comment.
I refactorized this part in the fixup, moving logic in DocSearchModal it would be cleaner I think.
AntoLC
force-pushed
the
refacto/search-no-child
branch
2 times, most recently
from
0eb8802 to
d8dfdb7
Compare
AntoLC
force-pushed
the
refacto/search-no-child
branch
from
d8dfdb7 to
72456ce
Compare
lunika
approved these changes
Jul 25, 2025
AntoLC
force-pushed
the
refacto/search-no-child
branch
from
72456ce to
835b5bd
Compare
When searching for documents, if no children are found, the search will now include all documents instead of just those with children.
AntoLC
force-pushed
the
refacto/search-no-child
branch
from
835b5bd to
1ae831c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When searching for documents, if no children are found, the search will now include all documents instead of just those with children.
Proposal