-
Notifications
You must be signed in to change notification settings - Fork 398
🔧(keycloak) Fix https required issue in dev mode. #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f1da4c9
to
e2c8aff
Compare
compose.yml
Outdated
- --proxy=edge | ||
- --hostname-url=http://localhost:8083 | ||
- --hostname-admin-url=http://localhost:8083/ | ||
# - --proxy=edge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# - --proxy=edge |
If it's not used, can it be removed?
compose.yml
Outdated
- --health-enabled=true | ||
- --metrics-enabled=true | ||
healthcheck: | ||
test: ["CMD", "curl", "--head", "-fsS", "http://localhost:8080/health/ready"] | ||
test: ['CMD-SHELL', '[ -f /tmp/HealthCheck.java ] || echo "public class HealthCheck { public static void main(String[] args) throws java.lang.Throwable { java.net.URI uri = java.net.URI.create(args[0]); System.exit(java.net.HttpURLConnection.HTTP_OK == ((java.net.HttpURLConnection)uri.toURL().openConnection()).getResponseCode() ? 0 : 1); } }" > /tmp/HealthCheck.java && java /tmp/HealthCheck.java http://localhost:9000/health/live'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it's not easier to remove the healthcheck instead of having to maintain this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it seems easier to maintain ? can be moved in a script.
['CMD-SHELL', 'exec 3<>/dev/tcp/localhost/9000; echo -e "GET /health/ready/live HTTP/1.1\r\nHost: localhost\r\nConnection: close\r\n\r\n" >&3; grep "HTTP/1.1 200 OK" <&3']
d2f9f01
to
c7b2995
Compare
5868180
to
858b506
Compare
858b506
to
753f1ff
Compare
On some environments keycloak returns a 'HTTPS required' message on login. The same issue was fixed in drive by changing the 'sslRequired' value from 'external' to 'none'. Also upgrade keycloak up to 26.3.2 Signed-off-by: Fabre Florian <[email protected]>
Fix the keyCloakSignIn() function for the new login page. Signed-off-by: Fabre Florian <[email protected]>
753f1ff
to
2085625
Compare
Purpose
On some environments keycloak returns a 'HTTPS required' message on login.
The same issue was fixed in drive by changing the 'sslRequired' value from 'external' to 'none' in all realms configuration (see suitenumerique/drive#291).
Also upgrade keycloak up to 26.3.2