🐛(back) allow ASCII characters in user sub field #1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbey
reviewed
Aug 26, 2025
src/backend/core/models.py
Outdated
| ), | ||
| ) | ||
|
|
||
| sub = models.CharField( | ||
| _("sub"), | ||
| help_text=_( | ||
| "Required. 255 characters or fewer. Letters, numbers, and @/./+/-/_/: characters only." | ||
| "Required. 255 characters or fewer. Letters, numbers, and @.+-_:=/ characters only." |
There was a problem hiding this comment.
Actually the OIDC spec says the sub can contain up to 255 ASCII characters (following RFC 20 https://www.rfc-editor.org/rfc/rfc20.txt)
Subject Identifier. A locally unique and never reassigned identifier within the Issuer for the End-User, which is intended to be consumed by the Client, e.g., 24400320 or AItOawmwtWwcT0k51BayewNvutrJUqsvl6qs7A4. It MUST NOT exceed 255 ASCII [RFC20] characters in length. The sub value is a case-sensitive string.
Should we be less restrictive?
There was a problem hiding this comment.
So we should remove the validator?
lunika
force-pushed
the
fix/user-sub-validator
branch
from
0ea8aba to
cd45ff6
Compare
lunika
changed the title
|
@qbey ASCII characters are allowed now. |
|
Size Change: -9 B (0%) Total Size: 3.6 MB |
qbey
approved these changes
Aug 29, 2025
lunika
force-pushed
the
fix/user-sub-validator
branch
3 times, most recently
from
64f8ae6 to
d556403
Compare
All ASCII characters are allowed in a sub, we change the sub validator to reflect this. Fix #1280
lunika
force-pushed
the
fix/user-sub-validator
branch
from
d556403 to
4f3430e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
All ASCII characters are allowed in a sub, we change the sub validator to reflect this.
Proposal
Fix #1280