Skip to content

Conversation

AlexB-mgtc
Copy link
Contributor

Purpose

Implement #778

Add support for specifying custom service accounts in all Kubernetes resources in our Helm charts to enable workload identity federation with managed cloud services (PostgreSQL, Redis, etc.). This allows deployments to authenticate to cloud resources without embedding credentials in secrets.

Proposal

This PR adds an optional serviceAccountName parameter to each component section in the Helm chart values that can be specified during deployment. When provided, the specified service account will be used for the corresponding Kubernetes resources.

✅ Add serviceAccountName field to Backend deployment and job templates
✅ Add serviceAccountName field to Frontend deployment template
✅ Add serviceAccountName field to Y-Provider deployment template
✅ Update values.yaml with new parameters and documentation
✅ Ensure backward compatibility with null default values
✅ Regenerate README.md
✅ Update CHANGELOG.md

Example usage in values.yaml:

backend:
  serviceAccountName: backend-sa  # For database access

frontend:
  serviceAccountName: frontend-sa  # For storage access

yProvider:
  serviceAccountName: yprovider-sa  # For collaboration services

@lunika
Copy link
Member

lunika commented Mar 25, 2025

Hi,
Thank you for your contribution.

In order to merge it can you please

Thanks.

@AntoLC AntoLC requested a review from Copilot July 18, 2025 08:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds service account support to Kubernetes resources in Helm charts to enable workload identity federation with cloud services. This allows deployments to authenticate to cloud resources without embedding credentials in secrets.

  • Adds optional serviceAccountName parameter to backend, frontend, and yProvider components
  • Updates all deployment and job templates to conditionally use the specified service account
  • Maintains backward compatibility with null default values

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/helm/impress/values.yaml Adds serviceAccountName parameters for backend, frontend, and yProvider components
src/helm/impress/templates/backend_deployment.yaml Adds conditional serviceAccountName to backend deployment
src/helm/impress/templates/backend_job_migrate.yaml Adds conditional serviceAccountName to migration job
src/helm/impress/templates/backend_job_createsuperuser.yaml Adds conditional serviceAccountName to superuser creation job
src/helm/impress/templates/frontend_deployment.yaml Adds conditional serviceAccountName to frontend deployment
src/helm/impress/templates/yprovider_deployment.yaml Adds conditional serviceAccountName to yProvider deployment
src/helm/impress/README.md Documents the new serviceAccountName parameters
CHANGELOG.md Records the new feature

@AntoLC AntoLC requested a review from rouja July 18, 2025 08:29
@AntoLC AntoLC added the helm label Jul 18, 2025
@AntoLC AntoLC force-pushed the main branch 2 times, most recently from a2bb354 to dd1affb Compare July 18, 2025 08:35
Copy link
Contributor

@rouja rouja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

This PR sounds good, but you forgot the celery worker.

Add support for specifying custom service accounts
in all Kubernetes resources in our Helm charts
to enable workload identity federation with managed
cloud services (PostgreSQL, Redis, etc.).
This allows deployments to authenticate to cloud
resources without embedding credentials in secrets.
@AntoLC AntoLC merged commit 67a195f into suitenumerique:main Jul 28, 2025
19 of 20 checks passed
@AlexB-mgtc
Copy link
Contributor Author

I didn't have the time to tidy up the PR myself, thanks for doing it!

@AntoLC
Copy link
Collaborator

AntoLC commented Jul 30, 2025

I didn't have the time to tidy up the PR myself, thanks for doing it!

Thank you for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants