Skip to content

✨(frontend) Interlinking doc #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 31, 2025
Merged

✨(frontend) Interlinking doc #904

merged 6 commits into from
Jul 31, 2025

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Apr 23, 2025 •
edited
Loading

Purpose

Interlinking: ability to mention a doc from another doc (Subpages).
Create connections between subpages directly within the editor.

More here: #679

Proposal

  • 🚚(frontend) reduce features coupling
  • ✨(frontend) create page from slash menu
  • ✨(frontend) interlinking custom inline content
  • ✨(frontend) create page from dropdown search
  • ✨(frontend) create editor shortcuts hook
  • exports PDF
  • export Docx
  • e2e tests

Demo

scrnli_ILshekaeTyer4O.webm

@AntoLC AntoLC self-assigned this Apr 23, 2025
@AntoLC AntoLC linked an issue Apr 23, 2025 that may be closed by this pull request
Interlinking: ability to mention a doc (Subpages Update) #679
Closed
@AntoLC AntoLC changed the base branch from main to feature/doc-dnd April 23, 2025 15:30
@AntoLC AntoLC marked this pull request as draft April 23, 2025 15:31
@AntoLC AntoLC force-pushed the feature/interlinking-doc branch 6 times, most recently from d8431c2 to 87cf9dc Compare April 29, 2025 12:55
@PanchoutNathan PanchoutNathan force-pushed the feature/doc-dnd branch 2 times, most recently from e7cf869 to 4fd4ea5 Compare May 12, 2025 14:15
This was referenced May 12, 2025
Closed
Open
@AntoLC AntoLC linked an issue May 13, 2025 that may be closed by this pull request
Interlinking: ability to mention a doc #597
Closed
@PanchoutNathan PanchoutNathan force-pushed the feature/doc-dnd branch 6 times, most recently from c904619 to 3bf4e7e Compare May 20, 2025 07:29
@PanchoutNathan PanchoutNathan force-pushed the feature/doc-dnd branch 5 times, most recently from 574c184 to 5057f4d Compare July 4, 2025 08:27
@lunika lunika force-pushed the feature/doc-dnd branch from 5057f4d to 79cdcc1 Compare July 4, 2025 08:42
@AntoLC AntoLC force-pushed the feature/interlinking-doc branch from eba4a68 to a15cf70 Compare July 18, 2025 15:35
@AntoLC AntoLC marked this pull request as ready for review July 18, 2025 15:39
@AntoLC AntoLC requested a review from lunika July 18, 2025 15:39
@virgile-dev
Copy link
Collaborator

Hey @AntoLC nice work!
Just tested it locally. Got a few feedbacks.
UI nitpicks
-> the width of the dropdown is a bit too small it should be more around 330px
-> the corner of the dropdown are blank
image

UX questions
-> could we suggest pages instead of showing "No document found" ?
image
-> I can only link documents from the parent document it'd be nice to be able to link document I have access to

@AntoLC AntoLC removed the request for review from lunika July 18, 2025 19:51
@AntoLC AntoLC force-pushed the feature/interlinking-doc branch 2 times, most recently from 504930f to e941c49 Compare July 23, 2025 09:47
@AntoLC
Copy link
Collaborator Author

AntoLC commented Jul 23, 2025 •
edited
Loading

@virgile-dev

UI nitpicks -> the width of the dropdown is a bit too small it should be more around 330px

Done, 330px for desktop, 220px for smaller.

the corner of the dropdown are blank

Fixed

could we suggest pages instead of showing "No document found" ?

Show now "Search by title"

I can only link documents from the parent document it'd be nice to be able to link document I have access to

Separate PR, like talk in meeting

@AntoLC AntoLC force-pushed the feature/interlinking-doc branch from e941c49 to 4314eb6 Compare July 23, 2025 10:15
@AntoLC AntoLC requested review from lunika and virgile-dev July 23, 2025 13:19
@virgile-dev
Copy link
Collaborator

virgile-dev commented Jul 25, 2025 •
edited
Loading

Hey @AntoLC thanks for the changes !
I see 2 last issues:

  • Minor: the parent page is not searchable (might be for a new PR)
  • When you update the title of a doc the interlink won't be updated ex bellow
Capture.video.du.25-07-2025.13.22.18.webm

@AntoLC AntoLC force-pushed the feature/interlinking-doc branch 2 times, most recently from d31cba6 to 85ca9ac Compare July 28, 2025 12:04
@AntoLC
Copy link
Collaborator Author

AntoLC commented Jul 28, 2025 •
edited
Loading

I see 2 last issues:

  • Minor: the parent page is not searchable (might be for a new PR):

Fixed here: #1243

  • When you update the title of a doc the interlink won't be updated ex bellow

It is updated now.

@AntoLC
🚚(frontend) reduce features coupling
f12d30c 
Move some components and assets to `doc-management`
to reduce coupling between features:
- SimpleDocItem from `doc-grid` to `doc-management`
- useCreateChildDoc from `doc-tree` to `doc-management`
- isOwnerOrAdmin from `doc-tree` to `doc-management`
@AntoLC AntoLC force-pushed the feature/interlinking-doc branch 3 times, most recently from c0ad223 to bb88699 Compare July 31, 2025 09:33
AntoLC added 2 commits July 31, 2025 12:57
@AntoLC
✨(frontend) create page from slash menu
afa48b6 
We are now able to create a new page from
the slash menu.
@AntoLC
✨(frontend) interlinking custom inline content
155e7df 
We want to be able to interlink documents in the editor.
We created a custom inline content that allows
users to interlink documents.
@AntoLC AntoLC force-pushed the feature/interlinking-doc branch from bb88699 to 476f918 Compare July 31, 2025 11:02
AntoLC added 3 commits July 31, 2025 13:26
@AntoLC
✨(frontend) create page from dropdown search
2a7c0ef 
We are now able to create a new page from
the dropdown search.
@AntoLC
✨(frontend) create editor shortcuts hook
e7709ba 
We created the editor shortcuts hook to handle
the shortcuts for the editor.
We implemented the following shortcuts:
- "@" to open the interlinking inline content
@AntoLC
✨(frontend) interlinking export
f5f9d8a 
Create interlinking link mapping for docx and pdf export.
@AntoLC AntoLC force-pushed the feature/interlinking-doc branch from 476f918 to f5f9d8a Compare July 31, 2025 11:26
@AntoLC AntoLC merged commit f5f9d8a into main Jul 31, 2025
20 of 21 checks passed
@AntoLC AntoLC deleted the feature/interlinking-doc branch July 31, 2025 11:46
@AntoLC AntoLC mentioned this pull request Jul 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunika lunika lunika approved these changes

@virgile-dev virgile-dev Awaiting requested review from virgile-dev

Assignees

@AntoLC AntoLC

Labels
editor frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interlinking: ability to mention a doc (Subpages Update) Interlinking: ability to mention a doc
3 participants
@AntoLC @virgile-dev @lunika